Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] PeerDB should enforce at most one row per public key hash #5169

Closed
jcnelson opened this issue Sep 12, 2024 · 1 comment
Closed

[Network] PeerDB should enforce at most one row per public key hash #5169

jcnelson opened this issue Sep 12, 2024 · 1 comment
Assignees
@jcnelson
Labels
3.0-must 3.0-Testing locked
Milestone
Nakamoto 3.0 - Te...

Comments

@jcnelson
Copy link
Member

Due to node churn, especially in NAT'ed automated clusters, it's possible that the same peer can be represented in multiple rows while having the same public key. Unfortunately, this isn't as simple as declaring the public key to be the primary key due to the way the PeerDB is structured.
@jcnelson jcnelson self-assigned this Sep 12, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Sep 12, 2024
@saralab saralab moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Sep 16, 2024
jcnelson added a commit that referenced this issue Sep 16, 2024
@jcnelson
fix: collate peers by public key and only report the one with the lat…
6c56f71 
…est last-contact time. Don't query rows in `frontier` directly, unless it's for a specific `slot` (fixes #5169)
@jcnelson jcnelson mentioned this issue Sep 16, 2024
Merged
@saralab saralab moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Sep 17, 2024
@saralab saralab closed this as completed Sep 17, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jcnelson jcnelson

Labels
3.0-must 3.0-Testing locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
Nakamoto 3.0 - Testnet Readiness
Development

No branches or pull requests
3 participants
@saralab @jcnelson @blockstack-devops