refactor: Rename --product-namespace to --namespace
#373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename fields in various structs to make clear what they are for
NickLarsenNZ
changed the title
--product-namespace to --namespace
Techassi
approved these changes
Apr 22, 2025
NickLarsenNZ
added a commit
that referenced
this pull request
Apr 22, 2025
They seemed to have been missed in #373
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
* feat: Support templating the namespace * changelog * changelog * changelog * changelog * Rename product_namespace to namespace * changelog * Apply suggestions from code review Co-authored-by: Techassi <git@techassi.dev> * chore: Update shell completions They seemed to have been missed in #373 --------- Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> Co-authored-by: Techassi <git@techassi.dev> Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
--product-namespaceto--namespace(the old argument still works and will be removed in a later release).Also rename fields in various structs to make clear what they are for.