Skip to content

feat: Support templating the namespace in manifests #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 23, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Feb 26, 2025

Description

Fixes #371
Also a bit of clean-up from #373

After this feature we should actually migrate demos to don't hard-code default.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@Techassi Techassi self-requested a review February 26, 2025 14:56
@sbernauer sbernauer requested review from Techassi and removed request for Techassi April 22, 2025 12:48
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Techassi
Techassi previously approved these changes Apr 22, 2025
@Techassi
Copy link
Member

One more note: Please make sure that the pre-commit checks pass.

NickLarsenNZ

This comment was marked as outdated.

Co-authored-by: Techassi <git@techassi.dev>
@NickLarsenNZ NickLarsenNZ dismissed stale reviews from Techassi and themself via 532979f April 22, 2025 17:28
They seemed to have been missed in #373
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 5a9a655 Apr 23, 2025
27 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/namespace-templating branch April 23, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⏲ Add namespace parameter support to demos/stacks (so we can avoid default for easier cleanup, and TLS certs for any NS)
3 participants