Skip to content

refactor: Rename --product-namespace to --namespace #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

refactor: Rename --product-namespace to --namespace #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
851ec06
refactor: Rename --product-namespace to --namespace
NickLarsenNZ Apr 22, 2025
590de44
chore: Add todo comments
NickLarsenNZ Apr 22, 2025
3c02e9d
chore: Update changelog
NickLarsenNZ Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions extra/completions/_stackablectl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions extra/completions/stackablectl.bash
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions extra/completions/stackablectl.elv
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions extra/completions/stackablectl.fish
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions extra/completions/stackablectl.nu
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/stackable-cockpit/src/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pub const DEFAULT_OPERATOR_NAMESPACE: &str = "stackable-operators";
// Currently lots of demos can only run in the default namespace, so we have to
// keep "default" here, until we switch the demos. We can't switch them right
// now, as the old stackablectl would break.
pub const DEFAULT_PRODUCT_NAMESPACE: &str = "default";
pub const DEFAULT_NAMESPACE: &str = "default";

pub const DEFAULT_LOCAL_CLUSTER_NAME: &str = "stackable-data-platform";

Expand Down
2 changes: 1 addition & 1 deletion rust/stackable-cockpit/src/platform/demo/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use crate::platform::operator::ChartSourceType;

pub struct DemoInstallParameters {
pub operator_namespace: String,
pub product_namespace: String,
pub demo_namespace: String,

pub stack_parameters: Vec<String>,
pub parameters: Vec<String>,
Expand Down
10 changes: 5 additions & 5 deletions rust/stackable-cockpit/src/platform/demo/spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ impl DemoSpec {
#[instrument(skip_all, fields(
stack_name = %self.stack,
operator_namespace = %install_parameters.operator_namespace,
product_namespace = %install_parameters.product_namespace,
demo_namespace = %install_parameters.demo_namespace,
))]
pub async fn install(
&self,
Expand All @@ -153,12 +153,12 @@ impl DemoSpec {
})?;

// Check demo prerequisites
self.check_prerequisites(client, &install_parameters.product_namespace)
self.check_prerequisites(client, &install_parameters.demo_namespace)
.await?;

let stack_install_parameters = StackInstallParameters {
operator_namespace: install_parameters.operator_namespace.clone(),
product_namespace: install_parameters.product_namespace.clone(),
stack_namespace: install_parameters.demo_namespace.clone(),
parameters: install_parameters.stack_parameters.clone(),
labels: install_parameters.stack_labels.clone(),
skip_release: install_parameters.skip_release,
Expand All @@ -185,7 +185,7 @@ impl DemoSpec {
#[instrument(skip_all, fields(
stack_name = %self.stack,
operator_namespace = %install_params.operator_namespace,
product_namespace = %install_params.product_namespace,
demo_namespace = %install_params.demo_namespace,
))]
async fn prepare_manifests(
&self,
Expand All @@ -204,7 +204,7 @@ impl DemoSpec {
Self::install_manifests(
&self.manifests,
&params,
&install_params.product_namespace,
&install_params.demo_namespace,
install_params.labels,
client,
transfer_client,
Expand Down
Loading
Loading