-
Notifications
You must be signed in to change notification settings - Fork 122
Subclass relevant classes from Enum #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge 0.3.2 changes into master
Merge 0.3.3 changes into master
0.4.0 - Merge develop to master
Merge version 0.5.0 - 0.5.2 into master
Merge 0.5.3 changes into master
Nice, thanks! Two other Enums to hit: |
@kylebarron good to go on this - but could you add a CHANGELOG.md entry? Still have to add that step to a PR template... |
Give me a minute to check on one thing before merging |
I think this should be ready to merge, thanks |
Codecov Report
@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
+ Coverage 93.73% 93.96% +0.23%
===========================================
Files 30 32 +2
Lines 3749 3996 +247
===========================================
+ Hits 3514 3755 +241
- Misses 235 241 +6
Continue to review full report at Codecov.
|
For #231. I'm guessing you only need the
__str__
override for theMediaType
class, since that's the only one that's likely to actually get printed?