Skip to content

Subclass relevant classes from Enum #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 19, 2021

Conversation

kylebarron
Copy link
Contributor

For #231. I'm guessing you only need the __str__ override for the MediaType class, since that's the only one that's likely to actually get printed?

@lossyrob
Copy link
Member

Nice, thanks! Two other Enums to hit:

@lossyrob
Copy link
Member

@kylebarron good to go on this - but could you add a CHANGELOG.md entry? Still have to add that step to a PR template...

@kylebarron
Copy link
Contributor Author

Give me a minute to check on one thing before merging

@kylebarron
Copy link
Contributor Author

I think this should be ready to merge, thanks

@codecov-io
Copy link

Codecov Report

Merging #261 (9f776b3) into develop (3ccb5d0) will increase coverage by 0.23%.
The diff coverage is 96.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #261      +/-   ##
===========================================
+ Coverage    93.73%   93.96%   +0.23%     
===========================================
  Files           30       32       +2     
  Lines         3749     3996     +247     
===========================================
+ Hits          3514     3755     +241     
- Misses         235      241       +6     
Impacted Files Coverage Δ
pystac/layout.py 94.44% <ø> (ø)
pystac/extensions/label.py 86.36% <75.00%> (-0.23%) ⬇️
pystac/link.py 97.43% <75.00%> (-0.81%) ⬇️
pystac/media_type.py 94.11% <75.00%> (-5.89%) ⬇️
pystac/catalog.py 95.67% <95.23%> (-0.17%) ⬇️
pystac/extensions/scientific.py 97.36% <97.36%> (ø)
pystac/extensions/sat.py 98.24% <98.24%> (ø)
pystac/__init__.py 100.00% <100.00%> (ø)
pystac/collection.py 97.44% <100.00%> (+0.46%) ⬆️
pystac/extensions/__init__.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccb5d0...9f776b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants