-
Notifications
You must be signed in to change notification settings - Fork 26
Create components based on visual design #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#53 is merged now, feel free to rebase |
d8b50f9
to
b752cbf
Compare
b752cbf
to
3a0c4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great!
I don't know if it's because maybe there is some work @ricardobaeta did after you created this branch, but the header is different to master.
In this screenshot master is on top, this branch on the bottom:
The differences are:
- Different left&right margins
- Missing breadcrumb items
- Wrong style for the dashboard link (it's not uppercase, and the hover color is not right)
Plus the breadcrumb links should probably have a different style on hover. Right now it's the only link with an underline on hover, and no color change. Maybe @ricardobaeta has a proposal for this.
|
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
links are fixed. All of them have the same hover style & uppercase. |
@smacker Let's start to tighten up our design. Please be so kind to address the margins issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@smacker As per our conversation, it's all good with the margins. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for clarifications!
Fixes: #64
This PR beings visual design from #53 but code is separated to reusable components.
It doesn't break other pages.