-
Notifications
You must be signed in to change notification settings - Fork 26
Reviewer UI (first version) #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
55916ba
to
086e9da
Compare
@smacker great! For changes that touch UI part, I find that also having a screenshot attached to PR helps to speed up the review process. |
@bzz screenshot added |
086e9da
to
2de0966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me.
I guess there will be subsequent tasks on using a mock data in components to show features, and then replacing it with real data from endpoint in #44
Looks like a very good first version I've seen just one issue, the contents appear to go past the width no matter my window size: And a couple of comments:
|
Thanks, @carlosms I didn't have the bug with the width of the table. Will try to reproduce. I want to rebase this PR using new components, so @ricardobaeta will be able to start doing visual design on this page without reimplementing the work he did already for annotation page. |
efa560c
to
36e9216
Compare
Rebased on #65 to unlock Ricardo. Problem with table width is fixed. |
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
36e9216
to
41cc887
Compare
Part of #47
Based on #45
It's a little different from wireframes:
P.S. There is some magic of mixing grid with flexbox because I had no choice.