Skip to content

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Feb 1, 2018

Part of #47

Based on #45

It's a little different from wireframes:

  1. There are no breadcrumbs
  2. Tables aren't scrollable, but tab content is. It's huge pain to make TBODY scrollable (actually you can't without overriding table layout by css) And then they are inside another flexible div. It's nightmare. I spent half of the day and almost implemented it. But it has too many hacks and I found few cases when it works wrong. We definitely need separate task for it or maybe @ricardobaeta can come up with another solution
  3. Better select control is implemented in @ricardobaeta PR, we will replace it later

P.S. There is some magic of mixing grid with flexbox because I had no choice.

screen shot 2018-02-02 at 14 39 28

@bzz
Copy link
Contributor

bzz commented Feb 2, 2018

@smacker great!

For changes that touch UI part, I find that also having a screenshot attached to PR helps to speed up the review process.

@bzz bzz requested review from bzz and dpordomingo February 2, 2018 10:20
@smacker
Copy link
Contributor Author

smacker commented Feb 2, 2018

@bzz screenshot added

@bzz bzz requested review from carlosms and removed request for dpordomingo February 8, 2018 09:24
Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

I guess there will be subsequent tasks on using a mock data in components to show features, and then replacing it with real data from endpoint in #44

@carlosms
Copy link
Contributor

carlosms commented Feb 8, 2018

Looks like a very good first version

I've seen just one issue, the contents appear to go past the width no matter my window size:
127 0 0 1_8080_review

And a couple of comments:

@smacker
Copy link
Contributor Author

smacker commented Feb 8, 2018

Thanks, @carlosms I didn't have the bug with the width of the table. Will try to reproduce.

I want to rebase this PR using new components, so @ricardobaeta will be able to start doing visual design on this page without reimplementing the work he did already for annotation page.

@smacker smacker force-pushed the reviewer_ui_init branch 2 times, most recently from efa560c to 36e9216 Compare February 8, 2018 11:58
@smacker
Copy link
Contributor Author

smacker commented Feb 8, 2018

Rebased on #65 to unlock Ricardo.
It looks like this now:

screen shot 2018-02-08 at 12 58 09

Problem with table width is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants