tests: asyncio: Fix Python 3.10 compatibility #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.10, the `asyncio.get_event_loop()` has been deprecated in favor of `asyncio.get_running_loop()`. That one, however, issues a warning when there's no event loop running (such as in this test suite). Fix this by always requesting a new event loop. These methods have been available since at least Python 3.5 (and there are no older docs online at this point). Bug: spulec#398
graingert
reviewed
Apr 11, 2022
| @@ -14,7 +14,7 @@ def test_time_freeze_coroutine(): | |||
| async def frozen_coroutine(): | |||
| assert datetime.date.today() == datetime.date(1970, 1, 1) | |||
|
|
|||
| asyncio.get_event_loop().run_until_complete(frozen_coroutine()) | |||
| asyncio.new_event_loop().run_until_complete(frozen_coroutine()) | |||
There was a problem hiding this comment.
Suggested change
| asyncio.new_event_loop().run_until_complete(frozen_coroutine()) | |
| asyncio.run(frozen_coroutine()) |
graingert
reviewed
Apr 11, 2022
| @@ -14,7 +14,7 @@ def test_time_freeze_coroutine(): | |||
| async def frozen_coroutine(): | |||
| assert datetime.date.today() == datetime.date(1970, 1, 1) | |||
|
|
|||
| asyncio.get_event_loop().run_until_complete(frozen_coroutine()) | |||
| asyncio.new_event_loop().run_until_complete(frozen_coroutine()) | |||
|
|
|||
|
|
|||
| def test_time_freeze_async_def(): | |||
There was a problem hiding this comment.
this test can just be removed because it's the same as the above test_time_freeze_coroutine - except the syntax was hidden from 3.4 or lower
micromoses
added a commit
to micromoses/freezegun
that referenced
this pull request
Feb 17, 2023
spulec#421 (comment) > this test can just be removed because it's the same as the above test_time_freeze_coroutine - except the syntax was hidden from 3.4 or lower
micromoses
added a commit
to micromoses/freezegun
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.10, the
asyncio.get_event_loop()has been deprecated in favor ofasyncio.get_running_loop(). That one, however, issues a warning when there's no event loop running (such as in this test suite).Fix this by always requesting a new event loop. These methods have been available since at least Python 3.5 (and there are no older docs online at this point).
Bug: #398