Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: asyncio: Fix Python 3.10 compatibility #421

Merged
merged 1 commit into from
Feb 17, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_asyncio.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_time_freeze_coroutine():
async def frozen_coroutine():
assert datetime.date.today() == datetime.date(1970, 1, 1)

asyncio.get_event_loop().run_until_complete(frozen_coroutine())
asyncio.new_event_loop().run_until_complete(frozen_coroutine())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asyncio.new_event_loop().run_until_complete(frozen_coroutine())
asyncio.run(frozen_coroutine())



def test_time_freeze_async_def():
Copy link
Contributor

@graingert graingert Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test can just be removed because it's the same as the above test_time_freeze_coroutine - except the syntax was hidden from 3.4 or lower

Expand All @@ -27,5 +27,5 @@ def test_time_freeze_async_def():
@freeze_time('1970-01-01')
async def frozen_coroutine():
assert datetime.date.today() == datetime.date(1970, 1, 1)
asyncio.get_event_loop().run_until_complete(frozen_coroutine())
asyncio.new_event_loop().run_until_complete(frozen_coroutine())
'''))