Py310 fix aio warning in ut #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.10, the `asyncio.get_event_loop()` has been deprecated in favor of `asyncio.get_running_loop()`. That one, however, issues a warning when there's no event loop running (such as in this test suite). Fix this by always requesting a new event loop. These methods have been available since at least Python 3.5 (and there are no older docs online at this point). Bug: spulec#398
Conflicts: .github/workflows/ci.yaml tox.ini
Up to python 3.10, staticmethods were not callable - so they were skipped by the condition.
Since python 3.10, staticmethods ARE callable - so adding the `isinstance(v, staticmethod)`
to the same `if` statement would consistently handle staticmethods across python
versions <=3.9 and >= 3.10.
This solves for:
```
self = <tests.test_datetimes.Tester object at 0x1073dc5e0>
def test_class_decorator_respects_staticmethod(self):
> assert self.helper() == datetime.date(2012, 1, 14)
tests/test_datetimes.py:453:
...
> result = func(*args, **kwargs)
E TypeError: Tester.helper() takes 0 positional arguments but 1 was given
freezegun/api.py:809: TypeError
```
spulec#421 (comment) > this test can just be removed because it's the same as the above test_time_freeze_coroutine - except the syntax was hidden from 3.4 or lower
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing for
tests/test_asyncio.py:17: DeprecationWarning: There is no current event loop.Based on #492 , merged from #421 , and including suggested changes by @graingert
cherry against 492: