Update config.yml #2240
Closed
Update config.yml #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps resource class to large for build jobs
gjedlicska
previously approved these changes
May 2, 2024
now using same resource class as the test job
iainsproat
reviewed
May 2, 2024
| @@ -784,7 +784,7 @@ jobs: | |||
|
|
|||
| docker-build: &build-job | |||
| docker: *docker-base-image | |||
| resource_class: medium | |||
There was a problem hiding this comment.
can we bump it for build-frontend-2 only?
docker-build-frontend-2:
<<: *build-job
resource_class: xlarge # I think this should override the referenced resource_class 🤞
environment:
SPECKLE_SERVER_PACKAGE: frontend-2
There was a problem hiding this comment.
would be cheaper, true :)
There was a problem hiding this comment.
looks like the job specific override does what I hoped it would do. I like when guesses like that work out 😄
|
closing as it was just a symptom of the real problem, see #2241 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps resource class to large for build jobs. See conversation on discord
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References