Fixed CI build error #2241
Merged
Fixed CI build error #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hough them at runtime
…hdri image.Now our IBL sources are finally straight not tilded 90 deg anymore. Added artificial shininess to all objects configurable in real time from the sandbox.
…pdated the sandbox to reflect the required AEC Aesthetics properties
…on, contrast and shininess are now in the 'post' folder and the hdri dropdown in the 'indirect light' folder. Cleaned up and renamed the available hdris to their descriptive names. The 'Mild' hdri is not set as the default one at library level
…lemented the artificial shininess as a real thing that the user can control
…e (8.3Mb) which is compiled together with the viewer library as base64 that was throwing something off. Because resizing the hdri to the old one's size (1025x512) was not enought (still amounted to 5.8Mb), we also applied a lossy compression algorithm namely DWAB to the image. This reduced the size to 330Kb with no visible tradeoff.
fabis94
approved these changes
May 3, 2024
didimitrie
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This fixes the CI build error caused by #2239
Turns out the culprit was the new hdri size of 8.3Mb which we include into the viewer build as base64 in order to avoid external fetches. After reducing the image size to the same as the old one (1024x512) the size was still 5.7Mb. Considering the old HDRI of identical size was only 1.1Mb a 5X increase in viewer build size is not really acceptable.
So we applied DWLB compression to the hdri via oiiotool CLI. This compression algorithm is lossy, but there is no visible tradeoff. That's mostly because we're not using the HDRI as is, but rather we're generating a small PMREM based on it and that's what we sample at runtime.
Because there is no visible reduction in quality, I'd say that a 3X reduction in size compared to the old HDRI and a 18X reduction compared to the PIZ lossless compression is definitely worth it.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References