Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.yml #2240

Closed
wants to merge 3 commits into from
Closed

Update config.yml #2240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
307bbe2
Update config.yml
didimitrie May 2, 2024
3495d21
Update config.yml
didimitrie May 2, 2024
4ab6c3b
Update config.yml
didimitrie May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ jobs:

docker-build: &build-job
docker: *docker-base-image
resource_class: medium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we bump it for build-frontend-2 only?

  docker-build-frontend-2:
    <<: *build-job
    resource_class: xlarge # I think this should override the referenced resource_class 🤞
    environment:
      SPECKLE_SERVER_PACKAGE: frontend-2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cheaper, true :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the job specific override does what I hoped it would do. I like when guesses like that work out 😄

resource_class: large
working_directory: *work-dir
steps:
- checkout
Expand Down Expand Up @@ -814,6 +814,7 @@ jobs:

docker-build-frontend-2:
<<: *build-job
resource_class: xlarge
environment:
SPECKLE_SERVER_PACKAGE: frontend-2

Expand Down