Move spaceros Base Image from docker to space-ros #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholum
force-pushed
the
move-space-ros-docker-image
branch
from
7629161
to
c2395aa
Compare
eholum
force-pushed
the
move-space-ros-docker-image
branch
2 times, most recently
from
1472b85
to
65b8d3f
Compare
mkhansenbot
requested changes
Jul 16, 2024
eholum
force-pushed
the
move-space-ros-docker-image
branch
from
65b8d3f
to
38bfa92
Compare
|
Also noted the bad issue links in all my commit messages, so I edited those and force-pushed the new messages with the appropriate link to the issue in the space ros repo. |
mkhansenbot
approved these changes
Jul 18, 2024
|
I'm not sure why CI is stuck on this, but it should be good to go at this point. |
eholum
force-pushed
the
move-space-ros-docker-image
branch
3 times, most recently
from
a008d3b
to
9123263
Compare
eholum
force-pushed
the
move-space-ros-docker-image
branch
from
9123263
to
cb71377
Compare
|
@mkhansenbot apologies for one more update but I changed the commit messages to point to the correct issue in the docker repo (#156). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156
We can merge this now that the spaceros build has been moved to the space-ros repo in: space-ros/space-ros#163
This removes references, CI, and documentation for the
spacerosimage, and adds a comment to the README pointing to the new location.