Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spaceros Base Image from docker to space-ros #151

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

eholum
Copy link
Contributor

@eholum eholum commented Jun 9, 2024

Resolves #156

We can merge this now that the spaceros build has been moved to the space-ros repo in: space-ros/space-ros#163

This removes references, CI, and documentation for the spaceros image, and adds a comment to the README pointing to the new location.

@eholum eholum force-pushed the move-space-ros-docker-image branch from 7629161 to c2395aa Compare June 9, 2024 16:59
@eholum eholum force-pushed the move-space-ros-docker-image branch 2 times, most recently from 1472b85 to 65b8d3f Compare June 25, 2024 12:18
@eholum eholum marked this pull request as ready for review June 25, 2024 12:18
Copy link
Contributor

@mkhansenbot mkhansenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good except for one minor wording change in the README.

space_robots/README.md Outdated Show resolved Hide resolved
@eholum eholum force-pushed the move-space-ros-docker-image branch from 65b8d3f to 38bfa92 Compare July 17, 2024 01:31
@eholum
Copy link
Contributor Author

eholum commented Jul 17, 2024

Also noted the bad issue links in all my commit messages, so I edited those and force-pushed the new messages with the appropriate link to the issue in the space ros repo.

@eholum eholum requested a review from mkhansenbot July 17, 2024 01:35
@eholum
Copy link
Contributor Author

eholum commented Jul 25, 2024

I'm not sure why CI is stuck on this, but it should be good to go at this point.

@eholum eholum force-pushed the move-space-ros-docker-image branch 3 times, most recently from a008d3b to 9123263 Compare July 26, 2024 12:26
@Bckempa Bckempa added this to the humble-2024.07.0 milestone Jul 30, 2024
@eholum eholum force-pushed the move-space-ros-docker-image branch from 9123263 to cb71377 Compare July 31, 2024 14:44
@eholum
Copy link
Contributor Author

eholum commented Jul 31, 2024

@mkhansenbot apologies for one more update but I changed the commit messages to point to the correct issue in the docker repo (#156).

@Bckempa Bckempa self-requested a review July 31, 2024 18:40
Copy link
Contributor

@Bckempa Bckempa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we have functional builds from the space-ros repo and are good to pull them out of here.

@Bckempa Bckempa merged commit ad020b8 into space-ros:main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove Earthfile from docker repo
3 participants