Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Earthfile from docker repo #156

Closed
Tracked by #107 ...
xfiderek opened this issue May 28, 2024 · 11 comments · Fixed by #151
Closed
Tracked by #107 ...

Remove Earthfile from docker repo #156

xfiderek opened this issue May 28, 2024 · 11 comments · Fixed by #151
Assignees

Comments

@xfiderek
Copy link
Contributor

xfiderek commented May 28, 2024

No description provided.

@xfiderek
Copy link
Contributor Author

@Bckempa suggestion - reconsider path / naming to the generate_repos.sh

@eholum
Copy link
Contributor

eholum commented May 31, 2024

I don't seem to have the power to assign myself issues but I'll plan on taking this on starting next week. @xfiderek can you assign to me?

@xfiderek
Copy link
Contributor Author

xfiderek commented Jun 1, 2024

I don't have permissions either. @EzraBrooks @Bckempa @mkhansenbot @ivanperez-keera, could you assign @eholum to this issue?

@Bckempa Bckempa assigned Bckempa and eholum and unassigned Bckempa Jun 2, 2024
@Bckempa
Copy link
Contributor

Bckempa commented Jun 2, 2024

Not sure what's up with permissions but I assigned @eholum (after misclicking and assigning myself...)

@eholum
Copy link
Contributor

eholum commented Jun 9, 2024

Step 1 to move the Earthfile and related content from docker to here is being done in: space-ros/space-ros#163.

As noted in the PR, I think it's preferable to test/merge that before moving onto other tasks that would make further modifications to the build process.

Step 2 to add additional options to the repos generation script has been added in: space-ros/space-ros#164

@eholum
Copy link
Contributor

eholum commented Jun 23, 2024

Still waiting on reviews for the two open PRs, but in the interim @xfiderek here is the basic consolidation of the repos file generation with the main build that you mentioned if you wanted to take a look. I just merged the two open PRs and made the changes based on that. It's WIP but give you an idea of what I was talking about...

eholum/space-ros#1

xfiderek referenced this issue in eholum/space-ros Jul 6, 2024
eholum referenced this issue in eholum/space-ros Jul 11, 2024
eholum referenced this issue in eholum/space-ros Jul 22, 2024
…tional Earthfile cleanup (space-ros/space-ros#158)
@EzraBrooks EzraBrooks changed the title Adjust main spaceros image to the new build approach Remove Earthfile from docker repo Jul 25, 2024
@eholum
Copy link
Contributor

eholum commented Jul 26, 2024

This will be resolved in #151.

@asimonov
Copy link

asimonov commented Jul 29, 2024

should this one be moved to docker?

in space-ros we have space-ros/space-ros#172 to cover this work?

@eholum
Copy link
Contributor

eholum commented Jul 29, 2024

Can we change this issue's repo? That would make sense to me as the PR is in the docker repo. We could also close this and open an alternate issue... As long as everything is linked from space-ros/space-ros#177.

@Bckempa
Copy link
Contributor

Bckempa commented Jul 30, 2024

should this one be moved to docker?

in space-ros we have space-ros/space-ros#172 to cover this work?

Edited your link to ensure it points to the proper issue after the move.

@Bckempa Bckempa transferred this issue from space-ros/space-ros Jul 30, 2024
@Bckempa Bckempa added this to the humble-2024.07.0 milestone Jul 30, 2024
@eholum
Copy link
Contributor

eholum commented Jul 31, 2024

Thanks @Bckempa! Sorry for the repo/issue nightmare that these changes have caused. I think everything looks right to me now. This will be closed by: #151.

eholum added a commit to eholum/docker that referenced this issue Jul 31, 2024
eholum added a commit to eholum/docker that referenced this issue Jul 31, 2024
eholum added a commit to eholum/docker that referenced this issue Jul 31, 2024
eholum added a commit to eholum/docker that referenced this issue Jul 31, 2024
Bckempa added a commit that referenced this issue Jul 31, 2024
…#156

Remove spaceros Base Image from docker repo in favor of build in space-ros repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants