Use bundle install before pod install when bundle is used #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakub-gonet
approved these changes
Oct 15, 2024
| { | ||
| shell: shouldUseBundle, // when using bundle, we need shell to run multiple commands | ||
| cwd: iosDirPath, | ||
| env: { ...env, LANG: "en_US.UTF-8" }, |
There was a problem hiding this comment.
Would be nice to add LANG automatically.
There was a problem hiding this comment.
I don't think we actually want to add it in all scenarios. I think we analyze the printed output here and so we add it such that we don't get the error messages translated.
p-malecki
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #617 we added an option for the IDE to use bundle command instead of pods directly as it is now recommended in new react native templates and setups. However, for bundle to work properly, we need to
bundle installfirst. This was missed in that PR as I was testing a project where bundle install has already run.This PR changes the pod installation command to:
bundle install && bundle exec pod installas recommended by react native docs. For this to work we passshelloption to the command which allows for joining the commands.How Has This Been Tested: