Use bundle and add proper logging for pod installation #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
p-malecki
reviewed
Oct 14, 2024
| @@ -155,7 +155,7 @@ export class DependencyManager implements Disposable, DependencyManagerInterface | |||
| return true; | |||
| } | |||
|
|
|||
| public async installPods(cancelToken: CancelToken) { | |||
| public async installPods(buildOutpuChannel: OutputChannel, cancelToken: CancelToken) { | |||
There was a problem hiding this comment.
typo:
buildOutpuChannel -> buildOutputChannel
p-malecki
reviewed
Oct 14, 2024
|
|
||
| try { | ||
| await cancelToken.adapt(commandInIosDir("pod install")); | ||
| lineReader(process).onLineRead((line) => buildOutpuChannel.appendLine(line)); |
There was a problem hiding this comment.
typo:
buildOutpuChannel -> buildOutputChannel
p-malecki
approved these changes
Oct 14, 2024
kmagiera
added a commit
that referenced
this pull request
Oct 15, 2024
In #617 we added an option for the IDE to use bundle command instead of pods directly as it is now recommended in new react native templates and setups. However, for bundle to work properly, we need to `bundle install` first. This was missed in that PR as I was testing a project where bundle install has already run. This PR changes the pod installation command to: `bundle install && bundle exec pod install` as recommended by react native docs. For this to work we pass `shell` option to the command which allows for joining the commands. ### How Has This Been Tested: 1. Delete rn 75 project and checkout a fresh copy 2. Open the fresh RN 75 project with the IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft as it is build on top of #615
This PR refactors the way we install pods in the IDE. The main objective is to optionally use
bundlecommand. This is similar to the changes proposed in #304 but apart from using bundle for the diagnostics check, we also use it when installing (which is a mechanism that wasn't in place when #304 was created).The second main change that we're making is that we trigger pod installation when clean build is requested. Before that wasn't happening.
On top of that, we are including pod command output in the iOS build log. This will help diagnose potential problems better and will also provide some feedback for the scenarios when installation take very long.
Finally, we are fixing the startup message component such that it resets long wait flag and we are also adding a more prominent message "open logs" for the native build phase. This way it should be easier to spot for the users that they can see the build output in case the build takes long:
How Has This Been Tested: