Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bundle install before pod install when bundle is used #624

Merged
merged 1 commit into from
Oct 15, 2024
+8 −4
Merged

Use bundle install before pod install when bundle is used #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/vscode-extension/src/dependency/DependencyManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,14 @@ export class DependencyManager implements Disposable, DependencyManagerInterface
try {
const env = getLaunchConfiguration().env;
const shouldUseBundle = await this.shouldUseBundleCommand();
const process = command(shouldUseBundle ? "bundle exec pod install" : "pod install", {
cwd: iosDirPath,
env: { ...env, LANG: "en_US.UTF-8" },
});
const process = command(
shouldUseBundle ? "bundle install && bundle exec pod install" : "pod install",
{
shell: shouldUseBundle, // when using bundle, we need shell to run multiple commands
cwd: iosDirPath,
env: { ...env, LANG: "en_US.UTF-8" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add LANG automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually want to add it in all scenarios. I think we analyze the printed output here and so we add it such that we don't get the error messages translated.

}
);
lineReader(process).onLineRead((line) => buildOutputChannel.appendLine(line));
await cancelToken.adapt(process);
} catch (e) {
Expand Down
Loading