Skip to content

fix: remove superfluous variable managed identity client id #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove superfluous variable managed identity client id #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions snakemake_executor_plugin_azure_batch/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,6 @@ class ExecutorSettings(ExecutorSettingsBase):
"env_var": True,
},
)
managed_identity_client_id: Optional[str] = field(
default=None,
repr=False,
metadata={
"help": "Azure Managed Identity client id.",
"required": False,
"env_var": True,
},
)
node_start_task_url: Optional[str] = field(
default=None,
metadata={
Expand Down
3 changes: 1 addition & 2 deletions snakemake_executor_plugin_azure_batch/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ def batch_pool_params(pool_id: str, settings, container_image: str) -> Pool:
"No container registry authentication scheme set. Please set the "
"SNAKEMAKE_AZURE_BATCH_CONTAINER_REGISTRY_USER and "
"SNAKEMAKE_AZURE_BATCH_CONTAINER_REGISTRY_PASS "
"or set SNAKEMAKE_AZURE_BATCH_MANAGED_IDENTITY_CLIENT_ID and "
"SNAKEMAKE_AZURE_BATCH_MANAGED_IDENTITY_RESOURCE_ID "
"or set SNAKEMAKE_AZURE_BATCH_MANAGED_IDENTITY_RESOURCE_ID "
"and Grant it permissions to the Azure Container Registry."
)

Expand Down
Loading