Skip to content

Conversation

@simonfelding
Copy link

@simonfelding simonfelding commented Oct 23, 2025

This doesn't do anything?

Summary by CodeRabbit

  • Breaking Changes
    • Removed the managed identity client ID configuration field. Users should now configure only the managed identity resource ID for Azure Batch operations.

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

This PR removes the managed_identity_client_id field from the ExecutorSettings dataclass and updates the batch pool parameters error message to no longer reference the related environment variable, streamlining the managed identity configuration API.

Changes

Cohort / File(s) Summary
Managed Identity Client ID Field Removal
snakemake_executor_plugin_azure_batch/__init__.py
Removed the public managed_identity_client_id: Optional[str] field from the ExecutorSettings dataclass
Environment Variable Documentation Update
snakemake_executor_plugin_azure_batch/build.py
Updated error message in batch_pool_params to remove reference to SNAKEMAKE_AZURE_BATCH_MANAGED_IDENTITY_CLIENT_ID, now only referencing SNAKEMAKE_AZURE_BATCH_MANAGED_IDENTITY_RESOURCE_ID

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title Check ✅ Passed The pull request title "fix: remove superfluous variable managed identity client id" directly and accurately describes the main changes in the changeset. The title clearly conveys that a managed identity client id variable is being removed, which aligns with the modifications shown: removal of the managed_identity_client_id field from ExecutorSettings and updates to related error messages. The title is concise, specific, and free of vague language or unnecessary noise, making it easy for teammates to understand the primary intent of the change when scanning the commit history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@simonfelding simonfelding changed the title remove managed identity client id fix: remove superfluous variable managed identity client id Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant