make default params available to serde #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, wasn't testing with --all-features... Needs more work. |
montanalow
force-pushed
the
montana/serde_default
branch
from
77b295d to
1e85bee
Compare
Codecov Report
@@ Coverage Diff @@
## development #167 +/- ##
===============================================
+ Coverage 84.40% 84.51% +0.10%
===============================================
Files 86 86
Lines 9921 9944 +23
===============================================
+ Hits 8374 8404 +30
+ Misses 1547 1540 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Rebased to pickup the seed params from the other PRs, and implemented defaults for all Enums for serde. |
morenol
approved these changes
Sep 22, 2022
morenol
added a commit
that referenced
this pull request
Sep 22, 2022
* Complete grid search params (#166) * grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup * Lmm/add seeds in more algorithms (#164) * Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> * add seed param to search params (#168) * make default params available to serde (#167) * add seed param to search params * make default params available to serde * lints * create defaults for enums * lint Co-authored-by: morenol <22335041+morenol@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
morenol
pushed a commit
that referenced
this pull request
Nov 8, 2022
* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #165 for all algorithms.