Complete grid search params #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to get this done before #165, since all of these search params will also require |
montanalow
commented
Sep 21, 2022
| /// Tolerance for stopping epoch. | ||
| pub tol: Vec<T>, | ||
| /// The kernel function. | ||
| pub kernel: Vec<K>, |
There was a problem hiding this comment.
This is the one param that it's currently impossible to meaningfully utilize, since we can't have multiple different K in the same Vec, but we can address that with a follow up PR.
|
ok just remember we will need your help to port this over to the new paradigm with 108 (; |
Mec-iS
approved these changes
Sep 21, 2022
I thought this would be orthogonal to the changes around arrays in 108, but happy to take a look if there is an issue. |
morenol
added a commit
that referenced
this pull request
Sep 22, 2022
* Complete grid search params (#166) * grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup * Lmm/add seeds in more algorithms (#164) * Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> * add seed param to search params (#168) * make default params available to serde (#167) * add seed param to search params * make default params available to serde * lints * create defaults for enums * lint Co-authored-by: morenol <22335041+morenol@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
morenol
pushed a commit
that referenced
this pull request
Nov 8, 2022
* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #154, that similarly adds iterable *SearchParameters for the remaining algorithms, so that they can also be used with
hyper_tuning::grid_search().Eqfor SVM Kernel structs to make them testable with assert_eq!