Lmm/add seeds in more algorithms #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #164 +/- ##
===============================================
+ Coverage 84.28% 84.34% +0.05%
===============================================
Files 85 86 +1
Lines 9215 9228 +13
===============================================
+ Hits 7767 7783 +16
+ Misses 1448 1445 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
morenol
force-pushed
the
lmm/add-seeds-in-more-algorithms
branch
from
37cca2a to
89d06e1
Compare
morenol
force-pushed
the
lmm/add-seeds-in-more-algorithms
branch
from
89d06e1 to
d5dbdbe
Compare
morenol
commented
Sep 20, 2022
| pub fn train_test_split<T: RealNumber, M: Matrix<T>>( | ||
| x: &M, | ||
| y: &M::RowVector, | ||
| test_size: f32, | ||
| shuffle: bool, | ||
| seed: Option<u64>, |
There was a problem hiding this comment.
Backward incompatible change that will require bump of version to 0.3
There was a problem hiding this comment.
To avoid breaking the API, an alternative would be to have a static rng, that can be seeded with an api call, and we could make that call at the start of tests.
There was a problem hiding this comment.
I think that we are going to do breaking changes in #108, so in my opinion we should not be worried about adding backward incompatible changes like this one as long as we document it in a changelog and we bump the version appropriately
Mec-iS
approved these changes
Sep 21, 2022
morenol
added a commit
that referenced
this pull request
Sep 22, 2022
* Complete grid search params (#166) * grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup * Lmm/add seeds in more algorithms (#164) * Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> * add seed param to search params (#168) * make default params available to serde (#167) * add seed param to search params * make default params available to serde * lints * create defaults for enums * lint Co-authored-by: morenol <22335041+morenol@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
morenol
added a commit
that referenced
this pull request
Nov 8, 2022
* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds seeds parameter to multiple algorithms (including SVC) in order to fix the flaky test by using a fixed seed for that test.
Fixes #158
Also, adding the capability to disable
stdfeature ofrandcrate so it can be used in WASM targets that don't havegetrandomsupport.Fixes #162
Adds a new
jsfeature that can be enabled in wasm targets for explicit browser support.