Added iOS 14 DatePickerStyle Support #488
Conversation
noorulain17
commented
Jul 8, 2020
noorulain17
commented
- Fixed crash in iOS 14.0
- Added iOS 14 DatePickerStyle Support
noorulain17
changed the title
| + (instancetype)showPickerWithTitle:(NSString *)title datePickerMode:(UIDatePickerMode)datePickerMode selectedDate:(NSDate *)selectedDate target:(id)target action:(SEL)action origin:(id)origin; | ||
|
|
||
| + (instancetype)showPickerWithTitle:(NSString *)title datePickerMode:(UIDatePickerMode)datePickerMode selectedDate:(NSDate *)selectedDate target:(id)target action:(SEL)action origin:(id)origin cancelAction:(SEL)cancelAction; | ||
| + (instancetype)showPickerWithTitle:(NSString *)title |
There was a problem hiding this comment.
Would be nice to pass the datePickerStyle. Default could be .automatic.
There was a problem hiding this comment.
Would you prefer converting this class to Swift or do the datePickerStyle changes in the current Objective C class?
There was a problem hiding this comment.
I think Objective C should be enough in this case.
noorulain17
force-pushed
the
ios14_support
branch
from
764a79a
to
c89e57c
Compare
|
Hey there, thanks for the work done here! Is there anyway I can help with this PR? We would like to update our project before iOS 14 launch 👼 |
From my point of view, it's done 👍 |
|
@KunzManuel so can we merge this PR? |
|
|
@KunzManuel can you please merge this PR? I don't have write access on this repository so can't merge. |
Neither do I, @ondererguven can merge this I guess ? |
|
I can't either because I don't have write access as well. @skywinder could you please merge this PR when you have the time? |
|
Hello, guys. I'm out of my mac for the next week. So can't even test it. If you are willing to help with maintaining this repo, I can add you as collaborators. |
|
And thank you for keep updated! |
- Added iOS 14 DatePickerStyle Support
noorulain17
force-pushed
the
ios14_support
branch
from
c89e57c
to
3debe8f
Compare
|
thanks, @noorulain17 Thank you for your support! 🎊 |
