Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionSheetDatePicker still crash in Xcode12 when set the datePickerStyle #498

Closed
jolyot opened this issue Sep 2, 2020 · 7 comments
Closed
Assignees

Comments

@jolyot
Copy link

jolyot commented Sep 2, 2020

Updating my project in Xcode12, and using pod v2.5.1.
#492 is supposed to be resolved in this PR, but ActionSheetDatePicker still crash.

What did you do?

When set the datePcikerStyle in the same way as this example, crash occurs with this error message

libc++abi.dylib: terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[ActionSheetDatePicker setDatePickerStyle:]: unrecognized selector sent to instance 0x158c1e070'
terminating with uncaught exception of type NSException

What did you expect to happen?

ActionSheetDatePicker does crash in Xcode12 when set the datePickerStyle

Environment

ActionSheetPicker_3_0 version: 2.5.1
Xcode version: 12.0 beta5

@noorulain17 noorulain17 self-assigned this Sep 3, 2020
@noorulain17
Copy link
Collaborator

noorulain17 commented Sep 3, 2020

I had tested this on Xcode 12.0 beta 1,
will check again on Xcode 12.0 beta 6 (as it's the latest) & update you.

@noorulain17
Copy link
Collaborator

noorulain17 commented Sep 3, 2020

@jolyot I updated ActionSheetPicker-3.0 to version 2.5.1 in a new sample project.
Tried on both Xcode 12.0 beta 1 & Xcode 12.0 beta 6 on simulators of iOS 13.4 & 14.0 with the sample code that you've mentioned above, app is working fine without any crash.

Xcode12beta1

Xcode12beta6

Can you please try updating the pod again? If the crash is still reproduced, please post a video/screenshot of it.

@jolyot
Copy link
Author

jolyot commented Sep 4, 2020

@noorulain17

Can you please try updating the pod again? If the crash is still reproduced, please post a video/screenshot of it.

OK! I will try!

@noorulain17
Copy link
Collaborator

Hey @jolyot ,
Any update on the issue?

@jolyot
Copy link
Author

jolyot commented Sep 18, 2020

@noorulain17
Sorry for the late reply.
I tried with Xcode12GM seed. It does not crash!
But layout is a little bit broken in iOS14 simulator.

datePickerStyle is automatic datePickerStyle is wheels
スクリーンショット 2020-09-18 19 18 57 スクリーンショット 2020-09-18 19 26 22

However, this issue is about the crash in Xcode12 and it does not occur in Xcode GM seed. So, I think this issue has been resolved.

@noorulain17
Copy link
Collaborator

Thanks @jolyot for the update.
Yes I've also noticed the broken layout in the latest Xcode version. I've started working on it and will soon release another stable version.

@jolyot
Copy link
Author

jolyot commented Sep 18, 2020

@noorulain17

I've started working on it and will soon release another stable version.

OK! I hope it will release soon!

@jolyot jolyot closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants