Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Collaborators to ActionSheetPicker-3.0 #348

Open
skywinder opened this issue May 24, 2017 · 34 comments
Open

Add more Collaborators to ActionSheetPicker-3.0 #348

skywinder opened this issue May 24, 2017 · 34 comments

Comments

@skywinder
Copy link
Owner

I want other people to feel like they own ActionSheetPicker-3.0, too, so it helps in the long run.

What I'm looking for is people who can:

  • Reply to questions.
  • Help diagnose/fix issues people have.
  • Help form a roadmap for future releases.

All when you have time and feel like it. It's not meant to be a burden.

Don't ever feel bad for not contributing to open source. —@alloy

Thanks to @searls for the push to do this by this talk.

If you're interested in helping out – when it's convenient for you – comment on this issue and I'll add you as a committer with push access.

Cheers! 😄 💻 🌍

/cc @ainopara @delackner @velga @kashifhisam @TimCinel

@xjki
Copy link
Collaborator

xjki commented Jul 25, 2017

Would be interested to help.

@skywinder
Copy link
Owner Author

@xjki @moheny if you are interested to help this project - I would be glad to make a work group with you 👍

@xjki
Copy link
Collaborator

xjki commented Sep 26, 2018

Let's give it a try.

@moheny
Copy link

moheny commented Sep 26, 2018

@skywinder Sure.

@skywinder
Copy link
Owner Author

awesome! Thanks for a quick response.
I'm here to gelp
Let's do it together. 👍
Here are some tasks:

  • Update project to the new Xcode version.
  • Here are 85 open issues
  • and 6 PR's.
  • Would be really appreciated to sort it out.

I will try to fix them all, and feel free to participate.
Becoming collaborator - is a kind of responsibility.
I would be glad to add initiative persons to collaborators after several reviews. 🎉

@xjki
Copy link
Collaborator

xjki commented Oct 3, 2018

It would be important for me to understand what is the strategy for maintaining library. For example - how many iOS versions back support is planned? (in my opinion - supporting current and 2 versions back is reasonable target), is rewrite to Swift a goal or is good compatibility enough? (issues asking for Swift support? rewrite?). Better Swift interop can be addressed with better header comments (or with Swift wrapper insetad of full rewrite). Also I think many of the issues are asking to address very specific edge cases (that in my opinion should not be in the scope of the library, like #355).

@skywinder skywinder reopened this Oct 23, 2019
@skywinder skywinder pinned this issue Oct 23, 2019
@skywinder
Copy link
Owner Author

Cc @BubiDevs (since you are actively working with this project 👍)

@jpmeenaa
Copy link

Would be interested to help.

@vincedev
Copy link

@skywinder , @Others
Also interested to help. I have forked the repository, but I admit I don't know where to start.
The repo has 94 active issues, 13 PR waiting, and worse, 46 branches 😳 ..
Is it possible to clean this repo before anything else ?

@andreabusi
Copy link
Collaborator

Hi @skywinder! I'm interested to help on this project, since I'm currently use the repo in a project.

As @vincedev noted, the repo needs some cleanup because there are some stuff that could be closed or removed.

Can we discuss an initial clean-up plan and an evolution process for this repo?

@skywinder
Copy link
Owner Author

skywinder commented Nov 26, 2019

@BubiDevs Grazie! I really appreciate your help. 🙏
send me please a message to Telegram (same nickname: skywinder) or email, let's arrange a small call and sync, what and how can we can do this.

p.s.
in which app are you using this library?

@skywinder
Copy link
Owner Author

@vincedev please, feel free to attend to our init call. let's arrange it together. I will get an intro, and will help to the cleanup repo and show how it works!
Same thing, send me a message to telegram/email. And let's arrange a call in zoom.

Thank you guys, you rock!

@andreabusi
Copy link
Collaborator

@BubiDevs Grazie! I really appreciate your help. 🙏
send me please a message to Telegram (same nickname: skywinder) or email, let's arrange a small call and sync, what and how can we can do this.

p.s.
in which app are you using this library?

Ok many thanks! I will add you on Telegram! 🚀

PS: I'm using this library in Syncrogest app, an app that I develop for a customer.

@skywinder
Copy link
Owner Author

@skywinder
Copy link
Owner Author

Hello! I updated pod, merged as much as I can. Now looks that it works on iOS 13 and all kind of iPads.

Thank you, everyone, for the support!
I also add contributors to the readme that help me a lot. (#451).

@skywinder
Copy link
Owner Author

skywinder commented Dec 11, 2019

@xjki, @BubiDevs thank you for continuous support and resolving the issues. Much appreciated!

Thanks for constant contributions and helping with answering to the questions. You help me a lot. 🖖So I will add you to collaborators. It will grant you access to repo management.

Congrats, and much appreciated! So welcome to Collaborators family! 🎉

@vincedev it's clean and up now. So feel free to use it. The up-to-date version in develop branch.

@skywinder
Copy link
Owner Author

skywinder commented Dec 11, 2019

or example - how many iOS versions back support is planned? (in my opinion - supporting current and 2 versions back is reasonable target), is rewrite to Swift a goal or is good compatibility enough? (issues asking for Swift support? rewrite?). Better Swift interop can be addressed with better header comments (or with Swift wrapper insetad of full rewrite). Also I think many of the issues are asking to address very specific edge cases (that in my opinion should not be in the scope of the library, like #355).

Update about your questions:

  1. I think we should stop support ios prior to 8.0 with the next major release. it will allow us to make much cleaner code.
  2. I want to test it on Swift 4.2 Swift 4.2 #401 (if someone can help to update/migrate it to modern Swift support - it would be cool. Just wondering, what range of swift versions can (and should) support. Thougts?

@andreabusi
Copy link
Collaborator

@xjki, @BubiDevs thank you for continuous support and resolving the issues. Much appreciated!

Thanks for constant contributions and helping with answering to the questions. You help me a lot. 🖖So I will add you to collaborators. It will grant you access to repo management.

Congrats, and much appreciated! So welcome to Collaborators family! 🎉

@vincedev it's clean and up now. So feel free to use it. The up-to-date version in develop branch.

Oh many thanks! Will be a pleasure to help on this repo! 🚀

@andreabusi
Copy link
Collaborator

andreabusi commented Dec 12, 2019

@skywinder this is my plan to discuss the evolution process of the repo:

  • create a dedicated issue on which discuss the proposals
  • create a branch (evolution-proposal)
  • in the new branch we will add a PROPOSAL.md file on which we will report all the decisions, and also we can link the open PR or issues on we are working on

What do you think?

PS: can we create a Slack workspace to discuss this general stuff?

@skywinder
Copy link
Owner Author

sounds good. Let's give a try!

a 5 cents from me:

  • About branch model: As for me - I prefer to do it in git-flow way with main development in develop and make a branch for each feature. We can do any kind of dev process - I'm open.

  • About communication - I'm also like slack more than other messengers. But in my experience Discord is more popular between open source projects. Proven by many projects. Again - I'm open to any option if it helps to the project!

@andreabusi
Copy link
Collaborator

andreabusi commented Dec 12, 2019

sounds good. Let's give a try!

a 5 cents from me:

  • About branch model: As for me - I prefer to do it in git-flow way with main development in develop and make a branch for each feature. We can do any kind of dev process - I'm open.

I'm not so used to git-flow but I can learn :P. For the specific case, I mean to create a branch on which put the work-in-progress PROPOSAL.md file. Could be feature/evolution-proposals the branch name?

  • About communication - I'm also like slack more than other messengers. But in my experience Discord is more popular between open source projects. Proven by many projects. Again - I'm open to any option if it helps to the project!

Ok, we can use Discord, no problem for me.

I will create the Discord project and the dedicated issue soon :)

@andreabusi
Copy link
Collaborator

Here is the link for Discord: https://discord.gg/jnYVY2

@skywinder
Copy link
Owner Author

skywinder commented Dec 21, 2019 via email

@andreabusi
Copy link
Collaborator

Invite doesn’t work feel free to to make a PR with permanent link, btw
On Fri, 13 Dec 2019 at 01:05, Andrea @.***> wrote: Here is the link for Discord: https://discord.gg/jnYVY2 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#348?email_source=notifications&email_token=AAZTOOXKFVYKBB7I2OGQQK3QYJVMLA5CNFSM4DMVEYS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXK27Q#issuecomment-565095806>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZTOOVXOPMZEJEPAR4HTALQYJVMLANCNFSM4DMVEYSQ .
-- --- Regards, Petr Korolev

My fault, I used a link with an expiration day.

I've made a PR with the right Discord link :)

@abdelmagied94
Copy link

@skywinder I would be glad to help

@skywinder
Copy link
Owner Author

@abdelmagied94 thank you, glad to hear. I would be very helpful with the 2 following things:

  • if you can go through issues and pull requests and review some of them and check issues. I closed 70% of them already but still need help.

  • test and Update readme with Carthage and Swift package manager options (I'm old school guy, who used Cocoapods, so didn't try new things yet)

@skywinder
Copy link
Owner Author

Please, have a look on #460

cc @abdelmagied94

@StefaniOSApps
Copy link

@BubiDevs Please, have a look on #460

@noorulain17
Copy link
Collaborator

@skywinder I would be glad to help 🎉

@skywinder
Copy link
Owner Author

@noorulain17 hooray! Are you using the library now? I would be glad. Can you please review open pull requests so that we can update the library for ios 14.0.

@noorulain17
Copy link
Collaborator

@noorulain17 hooray! Are you using the library now? I would be glad. Can you please review open pull requests so that we can update the library for ios 14.0.

@skywinder yeah I'm using this library in two of my apps that are live on AppStore.

Sure, I'll review the other open PRs, though I've opened the iOS 14.0 one.

@RahulTak
Copy link

would be glad to help you

Repository owner deleted a comment from yannvr Feb 23, 2024
@glennposadas
Copy link

We had a crash. I'll also contribute if the ticket and solution do not exist yet. Thanks for this!

@Wei18
Copy link
Collaborator

Wei18 commented Sep 21, 2024

@glennposadas

Thank you, glad to hear~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests