Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#picker ui not showing properly on ios 13 ipad #422

Closed
jpmeenaa opened this issue Sep 3, 2019 · 9 comments
Closed

#picker ui not showing properly on ios 13 ipad #422

jpmeenaa opened this issue Sep 3, 2019 · 9 comments
Labels

Comments

@jpmeenaa
Copy link

jpmeenaa commented Sep 3, 2019

Title bar of popup and UI not showing properly on iPad in iOS 13.
Uploading issue ios 13.png…

@adya
Copy link

adya commented Oct 14, 2019

Here is a working screenshot of "not showing properly" popup.
Basically, it looks like popup has some offset which is ignored by the top toolbar. And it results in toolbar being cut off a bit.

@jpmeenaa
Copy link
Author

I found the solution to this. I don't have knowledge about how to fork on github, I am learning about it and I will update it.

@Ankluas
Copy link

Ankluas commented Nov 5, 2019

@jpmeenaa Hey! I have the same problem, could you provide or explain the solution?

@jpmeenaa
Copy link
Author

jpmeenaa commented Nov 6, 2019

@skywinder skywinder added the bug label Nov 7, 2019
@skywinder
Copy link
Owner

skywinder commented Nov 7, 2019

@jpmeenaa did you fixed it? I'm out of iOS development now. WOuld you mind make PR and support this library?
I see you are doing new commits to your fork. We can merge our efforts to not generate new parallel instances.

I do my best to make this project alive.
Please, let me know, how to fix it.
I'm also would be glad for any help with this project. So if you are wondering about maintaining this project - please, let me know!
Here is a request topic, that I create about this: #348

@Ankluas
Copy link

Ankluas commented Nov 11, 2019

Could you please merge the fix regarding this bug with the ActionAheetPicker-3.0 version?

@skywinder
Copy link
Owner

I'm ready to review and merge shortly.
@Ankluas which PR are you referencing to?

@Ankluas
Copy link

Ankluas commented Dec 3, 2019

Hey there,

I am referencing the link given by @jpmeenaa
https://github.com/jpmeenaa/ActionSheetPicker
which should (?) fix the mentioned bug above. It seems like there is no PR for the ActionSheetPicker-3.0 if I didn't oversee it.

@skywinder
Copy link
Owner

skywinder commented Dec 10, 2019

I belive this bug was fixed by #444

Feel free to reopen/comment if you still have an issues.

Now everything should work fine! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants