Bump bingads version #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmosorast
approved these changes
Sep 21, 2020
prijendev
pushed a commit
that referenced
this pull request
Oct 7, 2021
* Update bingads package to version 13.0.4.1 * WIP * WIP * WIP * WIP * WIP * Require live connect * Bump to bingads to 13.0.5 * WIP * WIP * Make `require_live_connect` a config parameter, defaulting to True * require_live_connect will be a string, so read it as one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Bump bingads version and created an optional config parameter
require_live_connect, which defaults to True. If it is "False".Did not push the
bingadsversion all the way to13.0.5because13.0.4and beyond cause errors with the scope inside of thebingadspackage version.Reported the issue with scopes:
BingAds/BingAds-Python-SDK#164
Manual QA steps
Risks
Rollback steps