Bump bingads version (#63)

* Update bingads package to version 13.0.4.1 * WIP * WIP * WIP * WIP * WIP * Require live connect * Bump to bingads to 13.0.5 * WIP * WIP * Make `require_live_connect` a config parameter, defaulting to True * require_live_connect will be a string, so read it as one
singer-io · Sep 21, 2020 · 14fc3a2 · 14fc3a2
1 parent 9930d64
commit 14fc3a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -12,7 +12,7 @@
     py_modules=['tap_bingads'],
     install_requires=[
         'arrow==0.12.0',
-        'bingads==12.13.1',
+        'bingads==13.0.3',
         'requests==2.20.0',
         'singer-python==5.9.0',
         'stringcase==1.2.0',

diff --git a/tap_bing_ads/__init__.py b/tap_bing_ads/__init__.py
@@ -104,10 +104,13 @@ def create_sdk_client(service, account_id):
     LOGGER.info('Creating SOAP client with OAuth refresh credentials for service: %s, account_id %s',
                 service, account_id)
 
+    require_live_connect = CONFIG.get('require_live_connect', 'True') == 'True'
+
     authentication = OAuthWebAuthCodeGrant(
         CONFIG['oauth_client_id'],
         CONFIG['oauth_client_secret'],
-        '') ## redirect URL not needed for refresh token
+        '',
+        require_live_connect=require_live_connect) ## redirect URL not needed for refresh token
 
     authentication.request_oauth_tokens_by_refresh_token(CONFIG['refresh_token'])