Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bingads package to 13.0.4.1 #61

Closed
wants to merge 2 commits into from
Closed

update bingads package to 13.0.4.1 #61

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2020

Description of change

The tap is using an old bingads package. When I call it with my account, I get the following error:

image

After doing an upgrade to the current bingads package version 13.0.4.1, it works:

image

Rollback steps

  • revert this branch

@cosimon
Copy link
Contributor

cosimon commented Sep 21, 2020

The problem with your authentication is due to you not authenticating with the Live connect endpoint, which uses different scopes than the newer endpoint. In #63 we added an optional config parameter require_live_connect, which if you set to "False" will cause the tap to use the newer endpoint to retrieve its token. This should solve your authentication issues.

@cosimon cosimon closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants