-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement skips for stringify array format comma #304
Implement skips for stringify array format comma #304
Conversation
Is this PR done and ready to be re-reviewed? |
Yes it is. |
da64fb0
to
4c29858
Compare
4c29858
to
9fd5fa2
Compare
This is a breaking change to the default functionality of Anyone relying on the original behavior will now have different results after this change. Doesn't this require a major version revision? |
The documented default behaviour for |
The documented default behavior of The point I'm making is that this change breaks assumptions that already exist in the library that the I'd suggest releasing this change as a major revision to |
Fixes #302