Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.js #303

Closed
wants to merge 2 commits into from
Closed

Update index.js #303

wants to merge 2 commits into from

Conversation

decimoseptimo
Copy link
Contributor

Fixes #302

@decimoseptimo
Copy link
Contributor Author

please provide guidance

@sindresorhus
Copy link
Owner

You need to add some tests. Also, ensure running $ npm test locally passes.

@decimoseptimo decimoseptimo force-pushed the implement-skips-for-stringify-arrayFormat-comma branch from 0c04290 to c4ea916 Compare January 10, 2021 01:40
@sindresorhus
Copy link
Owner

sindresorhus commented Jan 12, 2021 •
edited
Loading

There's never any need to open a new PR. You can always just push to the existing one. Opening a new PR just creates noise in the issue tracker... #304

@decimoseptimo
Copy link
Contributor Author

sorry, i get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stringify isn't respecting skipNull nor skipEmptyString when arrayFormat: "comma"
2 participants
@decimoseptimo @sindresorhus