Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement skips for stringify array format comma #304

Merged
merged 8 commits into from
Mar 17, 2021
Merged

Implement skips for stringify array format comma #304

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce8beb1
Implement skips for stringify arrayFormat: "comma"
decimoseptimo Jan 9, 2021
c4ea916
Update tests
decimoseptimo Jan 10, 2021
032ff62
Add test with skipNull and skipEmptyString
decimoseptimo Feb 8, 2021
309a646
WIP ensure that parse() can handle what stringify() produces
decimoseptimo Feb 9, 2021
7479363
Add tests to ensure that parse() can handle stringify()
decimoseptimo Feb 9, 2021
7a1dfa9
Update readme.md
sindresorhus Mar 8, 2021
9fd5fa2
Sync readme.md and index.d.ts
decimoseptimo Mar 11, 2021
3c7e452
Update parse.js
sindresorhus Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,20 @@ function encoderForArrayFormat(options) {
case 'comma':
case 'separator':
return key => (result, value) => {
if (value === null || value === undefined || value.length === 0) {
if (
value === undefined ||
(options.skipNull && value === null) ||
(options.skipEmptyString && value === '')
) {
return result;
}

if (result.length === 0) {
return [[encode(key, options), '=', encode(value, options)].join('')];
return [[encode(key, options), '=', encode(value === null ? '' : value, options)].join('')];
}

if (value === null || value === '') {
return [[result, ''].join(options.arrayFormatSeparator)];
}

return [[result, encode(value, options)].join(options.arrayFormatSeparator)];
Expand Down
4 changes: 2 additions & 2 deletions test/stringify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ test('array stringify representation with array commas and null value', t => {
bar: [null]
}, {
arrayFormat: 'comma'
}), 'foo=a');
}), 'bar=&foo=,a,,');
decimoseptimo marked this conversation as resolved.
Show resolved Hide resolved
});

test('array stringify representation with array commas and 0 value', t => {
Expand All @@ -141,7 +141,7 @@ test('array stringify representation with array commas and 0 value', t => {
bar: [null]
}, {
arrayFormat: 'comma'
}), 'foo=a,0');
}), 'bar=&foo=a,,0');
});

test('array stringify representation with a bad array format', t => {
Expand Down