fix(chat-deploy): fixed form submission access patterns, fixed kb block filters

[waleedlatif1]

Description

Fixed form submission access patterns, fixed kb block filters

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally and in CI (bun run test)
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• I have updated version numbers as needed (if needed)
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

• My changes do not introduce any new security vulnerabilities
• I have considered the security implications of my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2025 5:46am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Aug 1, 2025 5:46am

[greptile-apps]

Greptile Summary

This PR addresses two main issues in the Sim platform: form submission access patterns for chat deployment and knowledge base (KB) block filtering functionality.

Chat Deployment Form Submission Fixes:
The changes refactor how chat deployment forms are handled in the DeployModal component. Previously, the system relied on DOM event listeners and querySelector to manage form submission, which could be unreliable. The new approach uses direct form access via getElementById and introduces a handleWorkflowPreDeploy function that ensures the main workflow is properly deployed before chat deployment begins. A new onPreDeployWorkflow callback prop is passed to the ChatDeploy component, establishing cleaner separation of concerns. The SuccessView component has been extracted to its own file, following the project's pattern of keeping rendered components separate from configuration.

Knowledge Base Block Filter Consolidation:
The PR consolidates the knowledge base tag filtering system by removing the singular KnowledgeTagFilter component and its associated type definition, standardizing on the plural KnowledgeTagFilters component. The KnowledgeTagFilters component receives a significant upgrade, transforming from a simple list-based interface to a comprehensive table-based UI with integrated TagDropdown functionality for variable suggestions. This new interface provides better visual organization, hover-to-delete patterns, and filter count indicators while maintaining backward compatibility with the existing JSON storage format.

Supporting Infrastructure:
A new barrel export file (hooks/index.ts) centralizes access to chat deployment hooks, and various UI improvements include adding autoComplete='new-password' to prevent browser interference with generated passwords and enhanced table row management with unique ID generation in the DocumentTagEntry component.

These changes integrate well with the existing ReactFlow-based workflow builder, maintaining consistency with other components that use tag dropdowns and following established patterns for component organization and state management.

Confidence score: 4/5

• This PR appears safe to merge with well-structured refactoring that improves reliability and user experience
• The score reflects the significant scope of changes across multiple components, particularly the complete rewrite of KnowledgeTagFilters, which increases the surface area for potential issues
• The KnowledgeTagFilters component needs careful testing due to its complete transformation from list-based to table-based UI

Context used:

Context - When defining properties for components, use a dedicated config file (.ts) for configuration and keep rendered components in their respective component files. (link)

_{10 files reviewed, 1 comment}

_{Edit Code Review Bot Settings | Greptile}