Skip to content

fix(sockets): duplicate block op should go through debounced path#834

Merged
icecrasher321 merged 1 commit intostagingfrom
fix/duplicate-block-sockets
Jul 31, 2025
Merged

fix(sockets): duplicate block op should go through debounced path#834
icecrasher321 merged 1 commit intostagingfrom
fix/duplicate-block-sockets

Conversation

@icecrasher321
Copy link
Collaborator

Description

Fix duplicate block operation for sockets client side handler to use collaborativeSetSubblockValue instead of directly setting store values. This makes sure it enters and is processed by ops queue correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Screen.Recording.2025-07-31.at.3.42.42.PM.mov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

Additional Information:

Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.

@vercel
Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 10:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 31, 2025 10:43pm

if (subBlockValues && activeWorkflowId) {
Object.entries(subBlockValues).forEach(([subblockId, value]) => {
subBlockStore.setValue(newId, subblockId, value)
collaborativeSetSubblockValue(newId, subblockId, value)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change -- rest is just rearranging

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a critical bug in the collaborative workflow system's duplicate block operation. When users duplicate blocks in the Sim workflow editor, the subblock values (configuration data within each block) need to be copied to the new block. Previously, the collaborativeDuplicateBlock function was directly calling subBlockStore.setValue() to copy these values, which bypassed the collaborative workflow's operation queue system.

The fix moves the collaborativeSetSubblockValue function definition earlier in the file (due to JavaScript hoisting requirements) and updates the duplicate operation to use this proper collaborative function instead of direct store access. This ensures that when a block is duplicated:

  1. The subblock value updates go through the debounced operation queue
  2. Other connected users receive the updates via socket synchronization
  3. The operations benefit from retry mechanisms and proper error handling
  4. State consistency is maintained across all collaborative sessions

This change integrates with Sim's real-time collaborative editing system, which uses WebSockets to synchronize workflow changes between multiple users. The collaborative workflow system maintains an operation queue that debounces rapid changes and ensures reliable delivery of updates to all connected clients.

Confidence score: 5/5

• This is a safe bug fix that improves consistency in the collaborative workflow system without breaking existing functionality
• The change follows established patterns in the codebase by using the proper collaborative function instead of bypassing the queue system
• No files need additional attention - the fix is well-contained and addresses the root cause directly

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@icecrasher321 icecrasher321 merged commit 84f095d into staging Jul 31, 2025
5 checks passed
icecrasher321 added a commit that referenced this pull request Aug 1, 2025
…n, deployed chat improvements (#843)

* fix(domain): fix telemetry endpoint, only add redirects for hosted version (#822)

* fix(otel): change back telemetry endpoint

* only add redirects for hosted version

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* fix(search-modal): fixed search modal keyboard nav (#823)

* fixed search modal keyboard nav

* break down file

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* improvement(docs): add base exec charge info to docs (#826)

* improvement(doc-tags-subblock): use table for doc tags subblock in create_document tool for KB (#827)

* improvement(doc-tags-subblock): use table for doc tags create doc tool in KB block

* enforce max tags

* remove red warning text

* fix(bugs): fixed rb2b csp, fixed overly-verbose logs, fixed x URLs (#828)

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* feat(wand): subblock level wand configuration + migrate old wand usage to this (#829)

* feat(wand): subblock level wand configuration + migrate old wand usage to this

* fix build issue

* Update apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/wand-prompt-bar/wand-prompt-bar.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* remove optional param

* remove unused test file

* address greptile comments

* change to enum for gen type

* fix caching issue

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* feat(tools): added hunter.io tools/block, added default values of first option in dropdowns to avoid operation selector issue, added descriptions & param validation & updated docs (#825)

* feat(tools): added hunter.io tools/block, added default values of first option in dropdowns to avoid operation selector issue

* fix

* added description for all outputs, fixed param validation for tools

* cleanup

* add dual validation, once during serialization and once during execution

* improvement(docs): add base exec charge info to docs (#826)

* improvement(doc-tags-subblock): use table for doc tags subblock in create_document tool for KB (#827)

* improvement(doc-tags-subblock): use table for doc tags create doc tool in KB block

* enforce max tags

* remove red warning text

* fix(bugs): fixed rb2b csp, fixed overly-verbose logs, fixed x URLs (#828)

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* fixed serialization errors to appear like execution errors, also fixed contrast on cmdk modal

* fixed required for tools, added tag dropdown for kb tags

* fix remaining tools with required fields

* update utils

* update docs

* fix kb tags

* fix types for exa

* lint

* updated contributing guide + pr template

* Test pre-commit hook with linting

* Test pre-commit hook again

* remove test files

* fixed wealthbox tool

* update telemetry endpoints

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>
Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>

* fix(deployed-chat): trigger blocks should not interfere with deployed chat exec (#832)

* fix(deployed-chat): allow non-streaming responses in deployed chat, allow partial failure responses in deployed chat (#833)

* fix(deployed-chat): allow non-streaming responses in deployed chat, allow partial failure responses in deployed chat

* fix(csp): runtime variable resolution for CSP

* cleanup

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* fix(sockets): duplicate block op should go through debounced path (#834)

* improvement(sockets): add batch subblock updates for duplicate to clear queue faster (#835)

* improvement(sockets): duplicate op should let addBlock take subblock values instead of separate looped op (#836)

* improvement(sockets): addBlock can accept subblock values

* cleanup unused code

* fix(deploy-modal): break down deploy modal into separate components (#837)

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* fix(kb-tags): docs page kb tags ui (#838)

* fix(kb-tags): docs page kb tags ui

* remove console logs

* remove console error

* fix(chat-deploy): fixed form submission access patterns, fixed kb block filters (#839)

* fix(chat-deploy): fixed form submission access patterns

* fix(kb-block): fix tag filters component, removed unused component

* fixed kb block subcomponents

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* fix(kb-tags): ui fixes, delete persistence for doc page header (#841)

* fix deletion of tags + refactor next slot calc

* fix kb tag filters count ui

* fix(chat-deploy): added new image upload component, fixed some state issues with success view (#842)

* fix(chat-deploy): added new image upload component, fixed some state issues with success view

* cleanup

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

* feat(deploy-chat): added a logo upload for the chat, incr font size

* fix(deploy-modal): break down deploy modal into separate components (#837)

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>

---------

Co-authored-by: waleedlatif <waleedlatif@waleedlatifs-MacBook-Pro.local>
Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@waleedlatif1 waleedlatif1 deleted the fix/duplicate-block-sockets branch August 2, 2025 22:18
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant