improvement(sockets): duplicate op should let addBlock take subblock values instead of separate looped op

[icecrasher321]

Description

Fixing duplicate op to pass in subblock values directly on the add block operation instead of doing batched update.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally and in CI (bun run test)
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• I have updated version numbers as needed (if needed)
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

• My changes do not introduce any new security vulnerabilities
• I have considered the security implications of my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2025 2:35am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Aug 1, 2025 2:35am

[greptile-apps]

Greptile Summary

This PR optimizes the block duplication workflow by eliminating the batch subblock update mechanism in favor of passing subblock values directly during the initial block creation operation. The changes remove the entire batch-subblock-update infrastructure across multiple layers of the application:

• Socket Layer: Removes the batch-subblock-update handler from subblocks.ts that processed multiple subblock updates in a single database transaction
• Operation Queue: Eliminates emitBatchSubblockUpdate function and its registration from the operation queue store
• Socket Context: Removes emitBatchSubblockUpdate and onBatchSubblockUpdate methods from the socket context interface
• Collaborative Workflow Hook: Modifies collaborativeDuplicateBlock to merge subblock values directly into the block payload before sending to the server

The key improvement is in the use-collaborative-workflow.ts file where the duplicate operation now:

1. Retrieves existing subblock values from the store
2. Merges them with the source block's subblock structure
3. Includes the merged subblocks directly in the duplicate operation payload
4. Applies values locally for immediate UI feedback

This change transforms the duplication process from a two-step operation (create block + batch update subblocks) into a single atomic operation, reducing network overhead and eliminating potential race conditions in collaborative editing scenarios. The approach aligns with existing patterns used in collaborativeAddBlock and leverages the existing mergeSubblockState utility function for consistent state management.

Confidence score: 4/5

• This change should improve performance and reliability by reducing socket operations and eliminating race conditions
• The implementation follows established patterns and maintains backward compatibility
• The removal of batch functionality could impact other use cases that relied on bulk subblock updates, though none are immediately apparent in the changed files

_{4 files reviewed, 5 comments}

_{Edit Code Review Bot Settings | Greptile}

[greptile-apps]

style: Empty line left after removing emitBatchSubblockUpdate - consider removing for cleaner formatting

Suggested change

	emitSubblockUpdate: (
	blockId: string,
	subblockId: string,
	value: any,
	operationId?: string
	) => void
	emitCursorUpdate: (cursor: { x: number; y: number }) => void

[greptile-apps]

style: Empty line left after removing onBatchSubblockUpdate - consider removing for cleaner formatting

Suggested change

	onSubblockUpdate: (handler: (data: any) => void) => void
	onCursorUpdate: (handler: (data: any) => void) => void

[greptile-apps]

style: Empty line left in eventHandlers type definition after removing batchSubblockUpdate property

Suggested change

	const eventHandlers = useRef<{
	workflowOperation?: (data: any) => void
	subblockUpdate?: (data: any) => void
	cursorUpdate?: (data: any) => void

[greptile-apps]

style: Empty line left in context provider value after removing emitBatchSubblockUpdate

Suggested change

	emitSubblockUpdate,
	emitCursorUpdate,

[greptile-apps]

style: Empty line left in context provider value after removing onBatchSubblockUpdate

Suggested change

	onSubblockUpdate,
	onCursorUpdate,