-
Notifications
You must be signed in to change notification settings - Fork 0
Use dev cfg for biasing, biassteps, bgmap. Remove fit_tmin kwarg #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* take_bias_steps and take_bgmap now work in a similar fashion to take_iv * Cfg files are generated with empty default dicts for each, which the user can modify * Moved `dc_voltage` param to take_bias_steps * Removed redundant docstring of take_bgmap
|
For justification of the |
|
I've tested bg_map, biasing, and bias_steps on an LF UFM in the Princeton testbed. I've tested analysis of historical bias step data from MF and UHF lab data, and UHF in-field data with and without a spinning HWP. This will change how time constants are computed for all frequencies, but it's strictly for the better. All previous time constants should be recomputed. |
|
I'm noticing now that the way I've implemented rfrac(range) defaults won't work with the way the pysmurf_controller and and sorunlib is written, and that those will also need to be changed. |
msilvafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments and questions along with a response to your question about rfrac vs rfrac_range inline.
|
I've implemented and tested my changes of merging bias_to_rfrac and bias_to_rfrac_range. It pulls from the dev cfg correctly, and the user can pass confused calls like |
msilvafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing and addressing comment.
This PR does several things related to biasing and bias steps:
Draft PR until I've been able to test all aspects of these changes.