Adds dev-cfg defaults for bias_steps and take_bgmap #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
approved these changes
Jan 3, 2024
Contributor
msilvafe
left a comment
msilvafe
left a comment
There was a problem hiding this comment.
This looks good, once we get to test this I'm happy to merge.
Collaborator
|
Done in #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same thing we did for the take_iv function, moving configuration params for
take_bias_stepsandtake_bgmapinto separate dataclasses so they can be more easily updated with defaults from the device cfg. This also simplifies a bit the storage of run config params and the passing of shared params between take_bgmap and take_bais_steps.This has not yet been tested.