pysmurf-controller: Update sodetlib version to v0.6.0 #957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This increments the sodetlib version to v0.6.0, which among other changes contains the following:
Use dev cfg for biasing, biassteps, bgmap. Remove fit_tmin kwarg (simonsobs/sodetlib#479)
dc_voltageparam out of take_bgmap and into take_bias_stepsMotivation and Context
The time constant fitting method needed fixing for UHF detectors, as described on Confluence here
Other changes move parameters from function calls into the device configuration file, to make the interface more similar to sodetlib.operations.take_iv, allowing special values to be passed without requiring custom lines in the scheduler.
To facilitate this, bias_to_rfrac and bias_to_rfrac_range have been merged into one function in sodetlib, and the default value of (0.3, 0.6) is now taken from the device config. The default value in the pysmurf_controller, and the if/else statement deciding which of these functions to call, have been removed.
Resolves #951.
How Has This Been Tested?
I've tested bg_map, biasing, and bias_steps on an LF UFM in the Princeton testbed. I've tested analysis of historical bias step data from MF and UHF lab data, and UHF in-field data with and without a spinning HWP.
All worked as expected.
I've implemented and tested my changes of merging bias_to_rfrac and bias_to_rfrac_range, again in the Princeton testbed, on an MF UFM. It pulls from the dev cfg correctly, and the user can pass confused calls like bias_to_rfrac(S,cfg, rfrac=(0.3, 0.6)) or bias_to_rfrac_range(S, cfg, rfrac=0.5) and those still work, too.
Types of changes
Checklist: