This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Expose updater symbols in flutter_windows.dll #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See shorebird/dev-3.24.5 for prior commit history.
* fix: update how we generate analyze_snapshot * formatting
…-export shorebird_check_for_update)
* chore: squash all our changes to a single commit See shorebird/dev-3.24.5 for prior commit history. * fix: remove flutter/fml/size include * fix: use shorebird buildroot * fix: generate analyze snapshot for arm builds * formatting * fix: update how we generate analyze_snapshot (#92) * fix: update how we generate analyze_snapshot * formatting * build windows * Windows Support * Format * Make patching work * Formatting * Formatting * Formatting * Improve windows * Formatting * Formatting * Formatting * Revert unneeded changes * Revert changes * Bump updater rev * Remove prints * Cleanup * fix deps * Use correct local appdata path * Formatting * consolidate fetching build number and release version * format * remove unnecessary pointer * Introduce ReleaseVersion struct * formatting * Formatting * More formatting * Comments * Formatting * More comments * Formatting * Remove print statements * Remove comments * Use in-out param for ConfigureShorebird * formatting * fix deps * Remove extra include of updater.lib * Cleanup * cleanup * Formatting * Use ERROR_SUCCESS * Do not use Error Success * Add comment * GetLocalAppDataPath feedback * Refactor --------- Co-authored-by: Felix Angelov <felix@shorebird.dev>
* feat: support intel macs * formatting * formatting * don't use linker on macos * cleanup * formatting * bump updater rev * SHOREBIRD_USE_LINKER -> SHOREBIRD_USE_INTERPRETER
* Add shorebird support to x64 Linux targets * formatting * read app id and version from files * Cleanup * Cleanup * add comment
eseidel
reviewed
Jan 30, 2025
| kDartIsolateSnapshotInstructions; | ||
| InternalFlutterGpu*; | ||
| kInternalFlutterGpu*; | ||
| _shorebird*; |
There was a problem hiding this comment.
This doesn't appear used on windows. flutter/build.gn:
config("export_dynamic_symbols") {
# --dynamic-list is the GNU linker syntax supported by ELF linkers.
# -exported_symbols_list is the macOS linker syntax. The different flags
# accept files formatted differently, so we have exported_symbols.sym for GNU
# linker syntax, and exported_symbols_mac.sym for the macOS linker syntax.
if (is_linux || is_fuchsia) {
inputs = [ "//flutter/common/exported_symbols.sym" ]
ldflags = [ "-Wl,--dynamic-list=" + rebase_path(inputs[0], root_build_dir) ]
} else if (is_mac) {
inputs = [ "//flutter/common/exported_symbols_mac.sym" ]
ldflags = [
"-Xlinker",
"-exported_symbols_list",
"-Xlinker",
rebase_path(inputs[0], root_build_dir),
]
}
}
bryanoltman
force-pushed
the
shorebird/dev
branch
from
899fa53 to
72a6ccc
Compare
felangel
force-pushed
the
shorebird/dev
branch
from
897caef to
e4575c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to get the shorebird_* functions from updater.h to be exposed in flutter_windows.dll so they can be used by
package:shorebird_code_pushvia ffi.None of this works yet.