This repository was archived by the owner on Feb 14, 2025. It is now read-only.
fix: update how we generate analyze_snapshot #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
approved these changes
Dec 13, 2024
felangel
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix: update how we generate analyze_snapshot * formatting
bryanoltman
added a commit
that referenced
this pull request
Jan 3, 2025
* chore: squash all our changes to a single commit See shorebird/dev-3.24.5 for prior commit history. * fix: remove flutter/fml/size include * fix: use shorebird buildroot * fix: generate analyze snapshot for arm builds * formatting * fix: update how we generate analyze_snapshot (#92) * fix: update how we generate analyze_snapshot * formatting * build windows * Windows Support * Format * Make patching work * Formatting * Formatting * Formatting * Improve windows * Formatting * Formatting * Formatting * Revert unneeded changes * Revert changes * Bump updater rev * Remove prints * Cleanup * fix deps * Use correct local appdata path * Formatting * consolidate fetching build number and release version * format * remove unnecessary pointer * Introduce ReleaseVersion struct * formatting * Formatting * More formatting * Comments * Formatting * More comments * Formatting * Remove print statements * Remove comments * Use in-out param for ConfigureShorebird * formatting * fix deps * Remove extra include of updater.lib * Cleanup * cleanup * Formatting * Use ERROR_SUCCESS * Do not use Error Success * Add comment * GetLocalAppDataPath feedback * Refactor --------- Co-authored-by: Felix Angelov <felix@shorebird.dev>
felangel
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix: update how we generate analyze_snapshot * formatting
felangel
added a commit
that referenced
this pull request
Jan 14, 2025
* chore: squash all our changes to a single commit See shorebird/dev-3.24.5 for prior commit history. * fix: remove flutter/fml/size include * fix: use shorebird buildroot * fix: generate analyze snapshot for arm builds * formatting * fix: update how we generate analyze_snapshot (#92) * fix: update how we generate analyze_snapshot * formatting * build windows * Windows Support * Format * Make patching work * Formatting * Formatting * Formatting * Improve windows * Formatting * Formatting * Formatting * Revert unneeded changes * Revert changes * Bump updater rev * Remove prints * Cleanup * fix deps * Use correct local appdata path * Formatting * consolidate fetching build number and release version * format * remove unnecessary pointer * Introduce ReleaseVersion struct * formatting * Formatting * More formatting * Comments * Formatting * More comments * Formatting * Remove print statements * Remove comments * Use in-out param for ConfigureShorebird * formatting * fix deps * Remove extra include of updater.lib * Cleanup * cleanup * Formatting * Use ERROR_SUCCESS * Do not use Error Success * Add comment * GetLocalAppDataPath feedback * Refactor --------- Co-authored-by: Felix Angelov <felix@shorebird.dev>
bryanoltman
added a commit
that referenced
this pull request
Feb 6, 2025
* fix: update how we generate analyze_snapshot * formatting
bryanoltman
added a commit
that referenced
this pull request
Feb 6, 2025
* chore: squash all our changes to a single commit See shorebird/dev-3.24.5 for prior commit history. * fix: remove flutter/fml/size include * fix: use shorebird buildroot * fix: generate analyze snapshot for arm builds * formatting * fix: update how we generate analyze_snapshot (#92) * fix: update how we generate analyze_snapshot * formatting * build windows * Windows Support * Format * Make patching work * Formatting * Formatting * Formatting * Improve windows * Formatting * Formatting * Formatting * Revert unneeded changes * Revert changes * Bump updater rev * Remove prints * Cleanup * fix deps * Use correct local appdata path * Formatting * consolidate fetching build number and release version * format * remove unnecessary pointer * Introduce ReleaseVersion struct * formatting * Formatting * More formatting * Comments * Formatting * More comments * Formatting * Remove print statements * Remove comments * Use in-out param for ConfigureShorebird * formatting * fix deps * Remove extra include of updater.lib * Cleanup * cleanup * Formatting * Use ERROR_SUCCESS * Do not use Error Success * Add comment * GetLocalAppDataPath feedback * Refactor --------- Co-authored-by: Felix Angelov <felix@shorebird.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in
lib/snapshot/BUILD.gn, we were no longer buildinganalyze_snapshotfor iOS. This change replaces our previouscreate_arm_analyze_snapshotwith something more in line with the ~equivalentcreate_macos_gen_snapshots.