Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Conversation

@bryanoltman
Copy link

@bryanoltman bryanoltman commented Jan 23, 2025

Updates the macOS platform to no longer use mixed mode, but instead swap the AOT snapshot at start time (as is done on Android and Windows). This works because macOS apps don't have the same restriction as iOS apps re: writing executable memory (or rather, developers are easily able to turn off that restriction).

@bryanoltman bryanoltman marked this pull request as ready for review January 24, 2025 19:24
@bryanoltman bryanoltman merged commit 994db67 into shorebird/dev Jan 24, 2025
1 check passed
@bryanoltman bryanoltman deleted the bo/intel-mac branch January 24, 2025 19:42
Copy link

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bryanoltman added a commit that referenced this pull request Feb 6, 2025
* feat: support intel macs

* formatting

* formatting

* don't use linker on macos

* cleanup

* formatting

* bump updater rev

* SHOREBIRD_USE_LINKER -> SHOREBIRD_USE_INTERPRETER
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants