Resubmit PR#2908+2951 Bot self identification and bug fix. #3625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…G_SPECIAL, The metadata can contain information about the bot status of the sender. It may also contain a system-injected notification that is displayed to the agent as part of the 1:1 chat window.
…essage on behalf of the system, optionally specify the agent id and name that should be used. (cherry picked from commit 7ff297e)
akleshchev
approved these changes
Feb 27, 2025
|
This looks good, but I'm gonna give this one some pause here so we can better incorporate some feedback before we merge it. Here's a couple of questions that I think that someone on Product should jump in on (@kylelinden - can you forward this to the right person?):
|
|
@Rider-Linden I'd say let's go ahead and get this merged into develop. Can you resolve the conflict on the message template? |
|
Sure thing. I've always thought we should remove that damn sha1 file from source control. It's generated as part of the build from message_template.msg. |
…tattle Fix conflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2908
Issue #2907
Process metadata sent along with chats of type `IM_NOTHING_SPECIAL', The metadata can contain information about the bot status of the sender. It may also contain a system-injected notification that is displayed to the agent as part of the 1:1 chat window.
Server PR https://github.com/secondlife/server/pull/1519
#2959
Adds optional parameters to addMessage which allow the function to override the icon and session name used for the chat while correctly naming and constructing the chat session.
See https://github.com/secondlife/server/pull/1519#issuecomment-2438596546 for issues addressed.