Fix for IM session name and icon. #2959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage on behalf of the system, optionally specify the agent id and name that should be used.
AndrewMeadows
approved these changes
Oct 25, 2024
akleshchev
reviewed
Oct 26, 2024
| @@ -3241,7 +3248,7 @@ void LLIMMgr::addMessage( | |||
| } | |||
|
|
|||
| //Play sound for new conversations | |||
| if (!skip_message & !gAgent.isDoNotDisturb() && (gSavedSettings.getBOOL("PlaySoundNewConversation"))) | |||
| if (!skip_message && !gAgent.isDoNotDisturb() && (gSavedSettings.getBOOL("PlaySoundNewConversation"))) | |||
There was a problem hiding this comment.
IMs aren't frequent, but probably better to use LLCachedControl here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional parameters to addMessage which allow the function to override the icon and session name used for the chat while correctly naming and constructing the chat session.
See https://github.com/secondlife/server/pull/1519#issuecomment-2438596546 for issues addressed.