Bot self identification. #2908
Merged
Bot self identification. #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…G_SPECIAL, The metadata can contain information about the bot status of the sender. It may also contain a system-injected notification that is displayed to the agent as part of the 1:1 chat window.
marchcat
approved these changes
Oct 21, 2024
AndrewMeadows
requested changes
Oct 23, 2024
| is_bot = metadata["sender"]["bot"].asBoolean(); | ||
| } | ||
| *----------------------------------------------------- | ||
| */ |
There was a problem hiding this comment.
The comment seems incorrect to assume the the sender has been flagged as a bot. For more correctness please indicate the server may or may not have flagged...
"The simulator has flagged this sender as a bot..." --> "The simulator may flag this sender as a bot in 'metadata'.
There was a problem hiding this comment.
"The simulator may have flagged...
| LLTrans::findString(buffer, notice_id, notice_args); | ||
| name = SYSTEM_FROM; | ||
| from_id = LLUUID::null; | ||
| } |
There was a problem hiding this comment.
Rather than bother with is_system_notice you could pivot on whether notice_id is interesting: if (notice_id.notNull()).
There was a problem hiding this comment.
Your comment also flagged for me that the name notice_id may be mistaken to be a UUID.
Changed to notice_name and test for empty.
AndrewMeadows
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2907
Process metadata sent along with chats of type `IM_NOTHING_SPECIAL', The metadata can contain information about the bot status of the sender. It may also contain a system-injected notification that is displayed to the agent as part of the 1:1 chat window.
Server PR https://github.com/secondlife/server/pull/1519