proposed BASE_PATH for webpack config.#4643
Closed
chrisgarrity wants to merge 1 commit intoscratchfoundation:scratch-desktop-updatefrom
Closed
proposed BASE_PATH for webpack config.#4643chrisgarrity wants to merge 1 commit intoscratchfoundation:scratch-desktop-updatefrom
chrisgarrity wants to merge 1 commit intoscratchfoundation:scratch-desktop-updatefrom
Conversation
cwillisf
reviewed
Mar 12, 2019
| var postcssVars = require('postcss-simple-vars'); | ||
| var postcssImport = require('postcss-import'); | ||
|
|
||
| const BASE_PATH = process.env.BASE_PATH || '/'; |
Contributor
There was a problem hiding this comment.
Judging by the way it's used, it looks like this might be more convenient / descriptive:
Suggested change
| const BASE_PATH = process.env.BASE_PATH || '/'; | |
| const STATIC_PATH = process.env.STATIC_PATH || '/static'; |
I defer to {@chrisG, @paulkaplan, @rschamp}'s opinion though ;)
Contributor
Author
|
Closing in favor of #4646 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these changes to the webpack config, and tried them with my local-www. So that part works. I didn't get to trying it with android (rebuilding gui with
BASE_PATH=""as part of the build)This is a PR on a PR, so I'm not sure what to label it :)
Also feel free to close if you find a better solution.