Set static asset path (publicPath) with environment var #4646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows consumers of gui (desktop, android, etc) to rebuild gui with a relative path for static assets. Default is an absolute path as that is what is required for www.
This was referenced Mar 13, 2019
paulkaplan
approved these changes
Mar 13, 2019
Contributor
paulkaplan
left a comment
paulkaplan
left a comment
There was a problem hiding this comment.
Seems fine to me. Let's make sure that rebuilding GUI with this param becomes part of the scratch-desktop build process, /cc @cwillisf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Part of #4598
Proposed Changes
Allows consumers of gui (desktop, android, etc) to rebuild gui with a relative path for static assets. Default is an absolute path as that is what is required for www.
Test Coverage
Please show how you have added tests to cover your changes
The default will build for www. With no changes to the build process it worked for my local www, and running gui locally (localhost:8601)
The android prototype npm linked to my local scratch-gui, all assets were fine after building gui with:
Assets checked:
/cc @rschamp @cwillisf
Note: we will have to figure out how to modify the scratch-desktop build process to automatically rebuild gui.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet