Skip to content

proposed BASE_PATH for webpack config. #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisgarrity wants to merge 1 commit into from
Closed

proposed BASE_PATH for webpack config. #4643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ var autoprefixer = require('autoprefixer');
var postcssVars = require('postcss-simple-vars');
var postcssImport = require('postcss-import');

const BASE_PATH = process.env.BASE_PATH || '/';
Copy link
Contributor

@cwillisf cwillisf Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the way it's used, it looks like this might be more convenient / descriptive:

Suggested change
const BASE_PATH = process.env.BASE_PATH || '/';
const STATIC_PATH = process.env.STATIC_PATH || '/static';

I defer to {@chrisG, @paulkaplan, @rschamp}'s opinion though ;)


const base = {
mode: process.env.NODE_ENV === 'production' ? 'production' : 'development',
devtool: 'cheap-module-source-map',
Expand Down Expand Up @@ -195,7 +197,7 @@ module.exports = [
output: {
libraryTarget: 'umd',
path: path.resolve('dist'),
publicPath: '/static/'
publicPath: `${BASE_PATH}static/`
},
externals: {
React: 'react',
Expand All @@ -208,7 +210,7 @@ module.exports = [
loader: 'file-loader',
options: {
outputPath: 'static/assets/',
publicPath: 'static/assets/'
publicPath: `${BASE_PATH}static/assets`
}
}
])
Expand Down