Allow moving an insertion marker leftwards #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By recognising an insertion marker as invalid if localConnection has changed, not just if highlightedConnection has changed.
| // with Web Blockly the name "highlightedConnection" will still be used. | ||
| if (Blockly.highlightedConnection_ && | ||
| Blockly.highlightedConnection_ != closestConnection) { | ||
| (Blockly.highlightedConnection_ != closestConnection || |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Collaborator
|
Nice catch. |
This was referenced Apr 20, 2016
thisandagain
pushed a commit
that referenced
this pull request
May 17, 2016
Fix scrollbar visibility when horizontal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you drag a pants block over another block, then try to drag it left so that it's before the other block, the insertion marker won't move until you drag away and return. This is nothing severe but slightly clunky.
dragging left before the fix
The expected behaviour can be achieved by patching updatePreviews to recognise an insertion marker as invalid if localConnection has changed, not just if highlightedConnection has changed.
dragging left after the fix
(the gifs were captured after rebasing onto bugfix/232 for clarity)