Skip to content

Allow moving an insertion marker leftwards #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drigz merged 2 commits into from
Apr 20, 2016
Merged

Allow moving an insertion marker leftwards #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9da3ddf
Allow moving an insertion marker leftwards
drigz Apr 19, 2016
6508ab4
Add null check
drigz Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/block_svg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,8 +998,9 @@ Blockly.BlockSvg.prototype.updatePreviews = function(closestConnection,
// Remove an insertion marker if needed. For Scratch-Blockly we are using
// grayed-out blocks instead of highlighting the connection; for compatibility
// with Web Blockly the name "highlightedConnection" will still be used.
if (Blockly.highlightedConnection_ &&
Blockly.highlightedConnection_ != closestConnection) {
if (Blockly.highlightedConnection_ && blockly.localConnection_ &&
(Blockly.highlightedConnection_ != closestConnection ||

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

Blockly.localConnection_ != localConnection)) {
if (Blockly.insertionMarker_ && Blockly.insertionMarkerConnection_) {
Blockly.BlockSvg.disconnectInsertionMarker();
}
Expand Down